-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[V1][Minor] Minor simplification for get_computed_blocks #16139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It might cause some confusion: if users send a prompt with its length divisible by the block size multiple times, they will find the hit rate is not 100%. However, it shouldn't be a big deal.
Signed-off-by: Woosuk Kwon <[email protected]>
…t#16139) Signed-off-by: Woosuk Kwon <[email protected]>
…t#16139) Signed-off-by: Woosuk Kwon <[email protected]> Signed-off-by: Yang Wang <[email protected]>
…t#16139) Signed-off-by: Woosuk Kwon <[email protected]>
…t#16139) Signed-off-by: Woosuk Kwon <[email protected]> Signed-off-by: Mu Huai <[email protected]>
prefix_cache_stats.queries
.