Skip to content

Conversation

reidliu41
Copy link
Contributor

@reidliu41 reidliu41 commented Apr 7, 2025

For llm_engine_example

  • add description
  • add print line to separate each print

For mlpspeculator

  • add description and note (not support in v1)
    raise NotImplementedError(
NotImplementedError: VLLM_USE_V1=1 is not supported with Speculative Decoding.
  • format the output
from:
.73 seconds
With speculation
Processed prompts: 100%|█| 1/1 [00:03<00:00,  3.54s/it, est. speed input: 12.73 toks/s, output: 44.9
Processed prompts: 100%|█| 1/1 [00:03<00:00,  3.00s/it, est. speed input: 14.98 toks/s, output: 52.9
Processed prompts: 100%|█| 1/1 [00:03<00:00,  3.00s/it, est. speed input: 14.99 toks/s, output: 52.9
0.018888232093187247
text: 'The current president of the United States is Joe Biden. He was inaugurated on January 20, 2021, and is serving his first term in office. Prior to his presidency, Biden served as Vice President under Barack Obama from 2009 to 2017. He has a long history of public service, including serving in the Senate for six terms from 1973 to 2009. Biden has been a strong advocate for progressive policies, including expanding access to healthcare, addressing climate change, and advancing civil rights. He has also been a vocal critic of President Donald Trump and has sought to undo many of the policies enacted during his presidency.'
[rank0]:[W407 16:14:49.860801583 ProcessGroupNCCL.cpp:1496] Warning: WARNING: destroy_process_group() was not called before program exit, which can leak resources. For more info, please see https://pytorch.org/docs/stable/distributed.html#shutdown (function operator())

to:
Processed prompts: 100%|█| 1/1 [00:03<00:00,  3.01s/it, est. speed input: 14.97 toks/s, output: 52.9
--------------------------------------------------
With speculation
time:  0.018905594663799933
text: 'The current president of the United States is Joe Biden. He was inaugurated on January 20, 2021, and is serving his first term in office. Prior to his presidency, Biden served as Vice President under Barack Obama from 2009 to 2017. He has a long history of public service, including serving in the Senate for six terms from 1973 to 2009. Biden has been a strong advocate for progressive policies, including expanding access to healthcare, addressing climate change, and advancing civil rights. He has also been a vocal critic of President Donald Trump and has sought to undo many of the policies enacted during his presidency.'
--------------------------------------------------
[rank0]:[W407 16:59:03.109660286 ProcessGroupNCCL.cpp:1496] Warning: WARNING: destroy_process_group() was not called before program exit, which can leak resources. For more info, please see https://pytorch.org/docs/stable/distributed.html#shutdown (function operator())

Copy link

github-actions bot commented Apr 7, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Apr 7, 2025
Signed-off-by: reidliu41 <[email protected]>
Signed-off-by: reidliu41 <[email protected]>
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 7, 2025 09:41
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 7, 2025
@DarkLight1337 DarkLight1337 merged commit dc3529d into vllm-project:main Apr 7, 2025
27 of 29 checks passed
lengrongfu pushed a commit to lengrongfu/vllm that referenced this pull request Apr 7, 2025
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants