Skip to content

config check sleep mode support oot platforms #16562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

config check sleep mode support oot platforms #16562

merged 1 commit into from
Apr 14, 2025

Conversation

celestialli
Copy link
Contributor

@celestialli celestialli commented Apr 14, 2025 •
edited by github-actions bot
Loading

FIX #16561

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@celestialli celestialli force-pushed the sleep branch 3 times, most recently from 4cca080 to 0335bcf Compare April 14, 2025 06:04
@celestialli
Copy link
Contributor Author

@simon-mo Hi, all runnable CIs have passed. Could you please review and merge this? Thanks.

@simon-mo simon-mo enabled auto-merge (squash) April 14, 2025 07:41
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 14, 2025
auto-merge was automatically disabled April 14, 2025 09:13

Head branch was pushed to by a user without write access

@celestialli
Copy link
Contributor Author

@simon-mo Hi, I have re-pushed because of CI fail for network reasons. So auto-merge seems to be disabled automatically. This PR is now ready to merge. Thanks.

@simon-mo simon-mo merged commit d2020ac into vllm-project:main Apr 14, 2025
41 checks passed
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@celestialli @yangw-dev
config check sleep mode support oot platforms (vllm-project#16562)
52f8cd1 
Signed-off-by: Yang Wang <[email protected]>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@celestialli @dbyoung18
config check sleep mode support oot platforms (vllm-project#16562)
8aa15aa
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@celestialli @lk-chen
config check sleep mode support oot platforms (vllm-project#16562)
780d2a9
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@celestialli
config check sleep mode support oot platforms (vllm-project#16562)
f079785 
Signed-off-by: Mu Huai <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
@celestialli celestialli mentioned this pull request Jun 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simon-mo simon-mo simon-mo approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: config init check sleep mode support oot platforms

2 participants

@celestialli @simon-mo