Skip to content

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented May 5, 2025

If we are converting directory x:

  • In x, we add a local pyproject.toml which:
    • overrides isort to use the black profile
    • overrides ruff's line length to 88 (it's own default)
    • removes the deprecated type ignores
    • enables formatting of code in docstrings (good for the API docs)
  • We add x to the list of files to run ruff-format on in .pre-commit-config.yaml
  • We add x to the list of ignores in the yapf config in the root pyproject.toml

@hmellor hmellor requested review from mgoin and simon-mo as code owners May 5, 2025 13:47
Copy link

github-actions bot commented May 5, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label May 5, 2025
@hmellor hmellor mentioned this pull request May 5, 2025
5 tasks
Copy link

mergify bot commented May 7, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @hmellor.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label May 7, 2025
hmellor added 2 commits May 7, 2025 10:12
Signed-off-by: Harry Mellor <[email protected]>
@mergify mergify bot removed the needs-rebase label May 7, 2025
Copy link
Collaborator

simon-mo commented May 8, 2025

How does this work for PR touching conflicting files? Is there a process for PR author to conduct a smooth rebase?

@hmellor
Copy link
Member Author

hmellor commented May 8, 2025

I would probably recommend that they run ruff format on the affected files in their PR.

Then, when they rebase, both sides of the diff will be ruff format and git will have a better time applying the PR on the new main.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 13, 2025 08:44
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 13, 2025
@DarkLight1337
Copy link
Member

DarkLight1337 commented May 13, 2025

More than one week has passed since the RFC #17657 so let's start!

@DarkLight1337 DarkLight1337 merged commit 98fcba1 into vllm-project:main May 13, 2025
35 checks passed
@hmellor hmellor deleted the ruff-format-buildkite branch May 13, 2025 10:07
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants