-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[New Model]: support GTE NewModel #17986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Head branch was pushed to by a user without write access
Unblocking extended LM tests |
Need to install MTEB for the tests |
Didn't you only test a few models before? MTEB has not merged my PR. ┓( ´∀` )┏ |
I mean the CI fails because of this |
What should I do? When testing only core_model before, we could skip test_models_mteb. |
You can add |
Signed-off-by: Yuqi Zhang <[email protected]>
Summary
Details
GTE NewModel
GTE NewModel uses NTKScalingRotaryEmbedding(RotaryEmbedding extended with fixed and mixed NTK scaling. https://kexue.fm/archives/9706)
Alibaba-NLP/gte-base-en-v1.5: type_vocab_size == 0
The second-generation GTE model (mGTE-TRM) is named
NewModel
. The nameNewModel
is too generic, you should set--hf-overrides '{"architectures": ["GteNewModel"]}'
to specify the use of theGteNewModel
architecture.numerical stability
BertModel require float32 to achieve relatively good numerical stability (<1e-4).
although torch_dtype is float16 in config.json. weird.
Other models can also achieve good results with float16.
Alibaba-NLP/gte-Qwen2-1.5B-instruct
Adding {"is_causal": True} can get results consistent with SentenceTransformer.
Not adding {"is_causal": True} can get better results on STS12 dataset
tests Involved
Fix #13616