Skip to content

Update deprecated type hinting in model_executor/layers #18056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

Update deprecated type hinting in model_executor/layers #18056

merged 1 commit into from
May 13, 2025

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented May 13, 2025

Removes deprecated Python 3.8 syntax.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added speculative-decoding tpu Related to Google TPUs labels May 13, 2025
DarkLight1337
DarkLight1337 approved these changes May 13, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating! I've wanted to do this for a while...

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 13, 2025 08:17
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 13, 2025
@vllm-bot vllm-bot merged commit 6223dd8 into vllm-project:main May 13, 2025
70 of 74 checks passed
@hmellor hmellor deleted the deprecated-typing-layers branch May 13, 2025 11:25
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
@hmellor @mawong-amd
Update deprecated type hinting in model_executor/layers (vllm-proje…
efe64e6 
…ct#18056)

Signed-off-by: Harry Mellor <[email protected]>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@hmellor
Update deprecated type hinting in model_executor/layers (vllm-proje…
ba94809 
…ct#18056)

Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@mgoin mgoin Awaiting requested review from mgoin mgoin is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner

@zhuohan123 zhuohan123 Awaiting requested review from zhuohan123

@youkaichao youkaichao Awaiting requested review from youkaichao

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat

@comaniac comaniac Awaiting requested review from comaniac

@njhill njhill Awaiting requested review from njhill

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed speculative-decoding tpu Related to Google TPUs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hmellor @DarkLight1337 @vllm-bot