Skip to content

Conversation

Akashcodes732
Copy link
Contributor

@Akashcodes732 Akashcodes732 commented Jun 3, 2025

This patch adds support for detecting POWER11 CPUs in cpu_extension.cmake.

Copy link

github-actions bot commented Jun 3, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Jun 3, 2025
@Akashcodes732 Akashcodes732 marked this pull request as draft June 3, 2025 14:49
Signed-off-by: Akash Kaothalkar <[email protected]>
@Akashcodes732 Akashcodes732 marked this pull request as ready for review June 4, 2025 05:49
@Akashcodes732
Copy link
Contributor Author

Hi @DarkLight1337, can someone please review this PR ?

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, LGTM

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) June 8, 2025 04:15
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 8, 2025
@DarkLight1337 DarkLight1337 merged commit b9a1791 into vllm-project:main Jun 8, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants