[Refactor] Remove unused variables in moe_permute_unpermute_kernel.inl

[yewentao256]

Purpose

Remove unused variables in moe_permute_unpermute_kernel.inl

So we don't have warnings like

moe_permute_unpermute_kernel.inl(23): warning #177-D: variable "align_expanded_row_accumulate" was declared but never referenced
    int64_t align_expanded_row_accumulate = 0;

[github-actions]

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

[gemini-code-assist]

Summary of Changes

Hello @yewentao256, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is a focused refactor to clean up the moe_permute_unpermute_kernel.inl file. It removes several variables that were identified as unused, which helps reduce code clutter and eliminates associated compiler warnings.

Highlights

• Code Cleanup: Removed four unused variables (align_expanded_row_accumulate, source_k_rank, row_rescale, and expert_idx) from the expandInputRowsKernel and finalizeMoeRoutingKernel functions within moe_permute_unpermute_kernel.inl.
• Warning Resolution: This change directly addresses and resolves compiler warnings related to these variables being declared but never referenced, as noted in the PR description.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively removes several unused variables from csrc/moe/permute_unpermute_kernels/moe_permute_unpermute_kernel.inl. These changes directly address compiler warnings and enhance code clarity by eliminating dead code. The review confirms that each removed variable was indeed unreferenced within its scope, and their removal is correct and beneficial for maintainability. No issues were identified in the applied changes; they successfully achieve the PR's stated goal.

No specific style guide was provided for this review. The feedback regarding the removal of unused variables aligns with general C++ best practices, such as those found in common style guides like the Google C++ Style Guide, which advocate for eliminating dead or unnecessary code to improve readability and maintainability.

[mgoin]

Thanks for the cleanup