-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[Perf] Reuse workspace for FP8+FP4 Marlin MoE #20500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Perf] Reuse workspace for FP8+FP4 Marlin MoE #20500
Conversation
Signed-off-by: mgoin <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @mgoin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request implements a targeted performance optimization for Marlin Mixture-of-Experts (MoE) operations, specifically for FP8 and FP4 quantization types. The core change involves modifying the call sites of the fused_marlin_moe
function to explicitly pass and reuse a pre-allocated workspace, thereby eliminating redundant memory allocations and enhancing the overall efficiency of these compute-intensive operations.
Highlights
- Performance Optimization: Ensured that
fused_marlin_moe
calls for FP8 and FP4 Mixture-of-Experts (MoE) operations consistently reuse a pre-allocatedlayer.workspace
. This prevents redundant memory allocations during each call, leading to improved efficiency. - Memory Efficiency: Addressed an oversight where
fused_marlin_moe
calls were not explicitly passed the pre-allocated workspace, potentially leading to unnecessary memory allocations. The fix ensures the existing workspace is utilized.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly addresses a performance issue by reusing a pre-allocated workspace for FP8 and FP4 Marlin MoE, which avoids repeated memory allocations. The changes are consistently applied across all relevant call sites in compressed_tensors_moe.py
, fp8.py
, and modelopt.py
. The implementation correctly passes the layer.workspace
attribute, which is initialized during the layer setup. The code is clean, and the fix is straightforward and correct. I find no issues with this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the work!
Signed-off-by: mgoin <[email protected]> Signed-off-by: Michael Goin <[email protected]> Co-authored-by: Wentao Ye <[email protected]>
Signed-off-by: mgoin <[email protected]> Signed-off-by: Michael Goin <[email protected]> Co-authored-by: Wentao Ye <[email protected]> Signed-off-by: charlifu <[email protected]>
Signed-off-by: mgoin <[email protected]> Signed-off-by: Michael Goin <[email protected]> Co-authored-by: Wentao Ye <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
Signed-off-by: mgoin <[email protected]> Signed-off-by: Michael Goin <[email protected]> Co-authored-by: Wentao Ye <[email protected]>
Purpose
All the call sites for
fused_marlin_moe
for FP8 and FP4 MoE methods were neglecting to pass in thelayer.workspace
that was pre-allocated by theprepare_moe_fp8_layer_for_marlin
andprepare_moe_fp4_layer_for_marlin
functions.This means that we were potentially allocating a new workspace (albeit small) on each
fused_marlin_moe
callvllm/vllm/model_executor/layers/fused_moe/fused_marlin_moe.py
Lines 115 to 116 in 3d184b9
Test Plan
CI and manual correctness tests. Will measure performance to look for potential small benefit
Test Result