Skip to content

Conversation

djmmoss
Copy link
Contributor

@djmmoss djmmoss commented Jul 8, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Enable CUTLASS block scaled grouped GEMM for small batch sizes.

Performance for the smaller sizes is roughly 1.2x-1.4x better than standard triton.

Test Plan

lm_eval --model vllm --model_args pretrained=/scratch/models/DeepSeek-R1,tensor_parallel_size=4,max_model_len=2048,gpu_memory_utilization=0.9,max_num_seqs=32 --trust_remote_code --tasks gsm8k --num_fewshot 5 --batch_size auto

Test Result

vllm (pretrained=/scratch/models/DeepSeek-R1,tensor_parallel_size=4,max_model_len=2048,gpu_memory_utilization=0.9,max_num_seqs=32,trust_remote_code=True), gen_kwargs: (None), limit: None, num_fewshot: 5, batch_size: auto
|Tasks|Version|     Filter     |n-shot|  Metric   |   |Value |   |Stderr|
|-----|------:|----------------|-----:|-----------|---|-----:|---|-----:|
|gsm8k|      3|flexible-extract|     5|exact_match|↑  |0.9507|±  | 0.006|
|     |       |strict-match    |     5|exact_match|↑  |0.9500|±  | 0.006|

(Optional) Documentation Update

Copy link

github-actions bot commented Jul 8, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @djmmoss, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the performance of grouped GEMM operations by extending the applicability of the highly optimized CUTLASS block scaled grouped GEMM kernel. By relaxing the input dimension constraints, the system can now leverage this faster implementation for a wider range of batch sizes, particularly benefiting smaller ones, leading to notable speedups in relevant computations.

Highlights

  • Performance Optimization: Enabled the use of CUTLASS block scaled grouped GEMM for smaller batch sizes by removing the minimum batch size (M >= 128) requirement in the _valid_cutlass_block_scaled_grouped_gemm_shape validation function. This change is expected to yield performance improvements of approximately 1.2x-1.4x for these smaller batch sizes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables the CUTLASS block-scaled grouped GEMM kernel for smaller batch sizes by removing the minimum batch size check. This change improves performance for smaller batch sizes. The review includes a suggestion to remove an unused parameter for better code maintainability.

@mgoin mgoin changed the title [feat] enable CUTLASS block scaled group gemm for smaller batch sizes [feat] enable SM100 CUTLASS block scaled group gemm for smaller batch sizes Jul 8, 2025
@mgoin
Copy link
Member

mgoin commented Jul 8, 2025

It would be helpful to have a kernel level result like benchmark_cutlass_fp4_moe.py but this result seems reasonable to me for Blackwell, thanks

@mgoin mgoin added performance Performance-related issues ready ONLY add when PR is ready to merge/full CI is needed labels Jul 8, 2025
@DarkLight1337 DarkLight1337 merged commit 97abeb1 into vllm-project:main Jul 9, 2025
76 checks passed
ant-yy pushed a commit to ant-yy/vllm that referenced this pull request Jul 9, 2025
@djmmoss djmmoss deleted the dmoss/enable_small_batch_size_ggemm_sm100 branch July 10, 2025 18:37
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Performance-related issues ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants