Skip to content

Conversation

yewentao256
Copy link
Member

@yewentao256 yewentao256 commented Jul 22, 2025

This reverts commit 6e5b5ca.

Purpose

#21208

Seems this break the compilation on AMD device, let's revert this first. And I will have another pr fixing the warning, and the same time having the AMD support as well, but it needs some time to set up the env for amd server, so let's just revert it first so that we don't block users

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts a previous commit, resolving a critical compilation issue on AMD devices. However, the reverted code reintroduces a deprecated CUDA API (cub::Sum) and a potentially unnecessary header (<cuda/std/functional>), which should be addressed in a follow-up PR to ensure long-term maintainability and avoid future compatibility issues.

@yewentao256 yewentao256 force-pushed the revert-21208-wye/fix-compie-warning branch from 86098ec to 7de9b54 Compare July 22, 2025 15:21
@vllm-bot vllm-bot merged commit 226b452 into vllm-project:main Jul 22, 2025
4 of 6 checks passed
@yewentao256 yewentao256 deleted the revert-21208-wye/fix-compie-warning branch July 22, 2025 15:22
zixi-qi pushed a commit to zixi-qi/vllm that referenced this pull request Jul 23, 2025
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants