-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
Revert "[Refactor] Fix Compile Warning #1444-D (#21208)" #21384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[Refactor] Fix Compile Warning #1444-D (#21208)" #21384
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request reverts a previous commit, resolving a critical compilation issue on AMD devices. However, the reverted code reintroduces a deprecated CUDA API (cub::Sum
) and a potentially unnecessary header (<cuda/std/functional>
), which should be addressed in a follow-up PR to ensure long-term maintainability and avoid future compatibility issues.
…ect#21208)" This reverts commit 6e5b5ca. Signed-off-by: yewentao256 <[email protected]>
86098ec
to
7de9b54
Compare
…ect#21208)" (vllm-project#21384) Signed-off-by: yewentao256 <[email protected]> Signed-off-by: qizixi <[email protected]>
…ect#21208)" (vllm-project#21384) Signed-off-by: yewentao256 <[email protected]> Signed-off-by: x22x22 <[email protected]>
…ect#21208)" (vllm-project#21384) Signed-off-by: yewentao256 <[email protected]>
…ect#21208)" (vllm-project#21384) Signed-off-by: yewentao256 <[email protected]>
…ect#21208)" (vllm-project#21384) Signed-off-by: yewentao256 <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
…ect#21208)" (vllm-project#21384) Signed-off-by: yewentao256 <[email protected]> Signed-off-by: Paul Pak <[email protected]>
…ect#21208)" (vllm-project#21384) Signed-off-by: yewentao256 <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
…ect#21208)" (vllm-project#21384) Signed-off-by: yewentao256 <[email protected]>
This reverts commit 6e5b5ca.
Purpose
#21208
Seems this break the compilation on AMD device, let's revert this first. And I will have another pr fixing the warning, and the same time having the AMD support as well, but it needs some time to set up the env for amd server, so let's just revert it first so that we don't block users