Skip to content

Conversation

WoosukKwon
Copy link
Collaborator

Add model code and config only. Need to add the MXFP4 MoE support for functionality.

Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
Copy link

github-actions bot commented Aug 6, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the new-model Requests to new models label Aug 6, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the GPT-OSS model, including its implementation, configuration, and registration in various registries. The model implementation appears to be a Mixture-of-Experts architecture. My review has identified a critical issue with device handling during weight loading and a high-severity issue with logging practices, both within the new vllm/model_executor/models/gpt_oss.py file.


for name, weight in weights:
# FIXME(woosuk): Remove this after testing.
weight = weight.cuda()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The hardcoded weight.cuda() call inside the weight loading loop is problematic. It prevents the model from running on non-CUDA devices (e.g., for testing on CPU) and is inefficient as it moves weights to the GPU one by one. This can lead to performance issues and portability problems. The weight loading pipeline should handle device placement, and this line should be removed. The FIXME comment suggests this might be temporary, but it's a critical issue to address before merging.

Signed-off-by: Woosuk Kwon <[email protected]>
@WoosukKwon WoosukKwon changed the title Add GPT-OSS model [1/N] Add GPT-OSS model code and config [1/N] Aug 6, 2025
@WoosukKwon WoosukKwon merged commit de98252 into main Aug 6, 2025
9 of 12 checks passed
@WoosukKwon WoosukKwon deleted the woosuk/gpt-oss-model branch August 6, 2025 06:26
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
myselvess pushed a commit to myselvess/vllm that referenced this pull request Aug 7, 2025
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
noamgat pushed a commit to noamgat/vllm that referenced this pull request Aug 9, 2025
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-model Requests to new models

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant