-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[Fix] remove is_marlin param in benchmark_moe #23286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Shixian Cui <[email protected]>
@mgoin could you take a look at this 1 line fix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly removes an extraneous is_marlin
parameter from the get_default_config
function call in benchmark_moe.py
. This change is necessary as the parameter does not exist in the function's signature, and its presence would lead to a TypeError
at runtime. The fix is straightforward and resolves the issue.
Thanks for finding, I left this behind |
Signed-off-by: Duncan Moss <[email protected]>
Signed-off-by: Xiao Yu <[email protected]>
Purpose
1 line fix to remove extra
is_marlin
param in benchmark_moe.py after PR #23006Test Plan
python3 benchmark_moe.py
Test Result
python3 benchmark_moe.py passed
(Optional) Documentation Update
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.