-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
Remove graph_pool as member of VllmBackend and argument to CUDAGraphWrapper #23385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vllm-bot
merged 3 commits into
main
from
copilot/fix-f1ddac43-4315-4814-a414-33427a5334bc
Aug 26, 2025
Merged
Remove graph_pool as member of VllmBackend and argument to CUDAGraphWrapper #23385
vllm-bot
merged 3 commits into
main
from
copilot/fix-f1ddac43-4315-4814-a414-33427a5334bc
Aug 26, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Co-authored-by: ProExpertProg <[email protected]>
Copilot finished work on behalf of
ProExpertProg
August 21, 2025 22:33
Signed-off-by: Luka Govedič <[email protected]>
jikunshang
approved these changes
Aug 23, 2025
zou3519
approved these changes
Aug 25, 2025
tc-mb
pushed a commit
to tc-mb/vllm
that referenced
this pull request
Aug 27, 2025
…rapper (vllm-project#23385) Signed-off-by: Luka Govedič <[email protected]> Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: ProExpertProg <[email protected]> Co-authored-by: Luka Govedič <[email protected]> Signed-off-by: tc-mb <[email protected]>
epwalsh
pushed a commit
to epwalsh/vllm
that referenced
this pull request
Aug 28, 2025
…rapper (vllm-project#23385) Signed-off-by: Luka Govedič <[email protected]> Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: ProExpertProg <[email protected]> Co-authored-by: Luka Govedič <[email protected]>
xiao-llm
pushed a commit
to xiao-llm/vllm
that referenced
this pull request
Aug 28, 2025
…rapper (vllm-project#23385) Signed-off-by: Luka Govedič <[email protected]> Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: ProExpertProg <[email protected]> Co-authored-by: Luka Govedič <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
zhewenl
pushed a commit
to zhewenl/vllm
that referenced
this pull request
Aug 28, 2025
…rapper (vllm-project#23385) Signed-off-by: Luka Govedič <[email protected]> Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: ProExpertProg <[email protected]> Co-authored-by: Luka Govedič <[email protected]>
zhewenl
pushed a commit
to zhewenl/vllm
that referenced
this pull request
Sep 3, 2025
…rapper (vllm-project#23385) Signed-off-by: Luka Govedič <[email protected]> Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: ProExpertProg <[email protected]> Co-authored-by: Luka Govedič <[email protected]>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
…rapper (vllm-project#23385) Signed-off-by: Luka Govedič <[email protected]> Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: ProExpertProg <[email protected]> Co-authored-by: Luka Govedič <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
graph_pool
as a member variable ofVllmBackend
and as an argument toCUDAGraphWrapper
and its base classAbstractStaticGraphWrapper
. Instead,CUDAGraphWrapper
now always obtains the graph pool directly from the platform usingcurrent_platform.get_global_graph_pool()
.Changes Made
1. AbstractStaticGraphWrapper Protocol
graph_pool: Any
parameter from__init__
method signature2. CUDAGraphWrapper
graph_pool: Any = None
parameter from constructorgraph_pool
was None3. VllmBackend
self.graph_pool
member variable from__init__
graph_pool: Any
from class type annotationsPiecewiseCompileInterpreter
to not take or usegraph_pool
parametergraph_pool
argumentRationale
This change simplifies the architecture by removing an unnecessary parameter that was being passed around when the graph pool can be obtained directly from the platform. The existing fallback logic in
CUDAGraphWrapper
already calledcurrent_platform.get_global_graph_pool()
whengraph_pool=None
, so this change makes that the default behavior while eliminating the parameter passing overhead.Backward Compatibility
This is a breaking change for any external code that:
CUDAGraphWrapper
with thegraph_pool
argumentgraph_pool
member ofVllmBackend
AbstractStaticGraphWrapper
with the old signatureHowever, all internal usage has been updated and existing tests continue to work without modification.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.