-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[Kernel] Update DeepGEMM to latest commit #23915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jee Jee Li <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the DeepGEMM dependency to a more recent commit to resolve a runtime error. The change is straightforward and correct. I've identified a code duplication issue where the git commit hash is defined in both the Dockerfile and a shell script. I've suggested a refactoring to make the shell script the single source of truth, which will improve maintainability and prevent potential inconsistencies between Docker builds and local script execution.
docker/Dockerfile
Outdated
ARG DEEPGEMM_GIT_REF="ea9c5d9270226c5dd7a577c212e9ea385f6ef048" | ||
COPY tools/install_deepgemm.sh /tmp/install_deepgemm.sh | ||
RUN --mount=type=cache,target=/root/.cache/uv \ | ||
VLLM_DOCKER_BUILD_CONTEXT=1 /tmp/install_deepgemm.sh --cuda-version "${CUDA_VERSION}" --ref "${DEEPGEMM_GIT_REF}" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The DEEPGEMM_GIT_REF
is defined in both docker/Dockerfile
and tools/install_deepgemm.sh
. This duplication can lead to inconsistencies if one is updated and the other is not. To improve maintainability and make tools/install_deepgemm.sh
the single source of truth for the default git reference, I suggest removing the hardcoded value from the Dockerfile and conditionally passing the --ref
argument only when DEEPGEMM_GIT_REF
is provided as a build argument.
ARG DEEPGEMM_GIT_REF
COPY tools/install_deepgemm.sh /tmp/install_deepgemm.sh
RUN --mount=type=cache,target=/root/.cache/uv \
VLLM_DOCKER_BUILD_CONTEXT=1 /tmp/install_deepgemm.sh --cuda-version "${CUDA_VERSION}" ${DEEPGEMM_GIT_REF:+--ref "$DEEPGEMM_GIT_REF"} \
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this actually works, I'd prefer it
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
e8ff282
to
892c1c2
Compare
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the work!
Signed-off-by: Jee Jee Li <[email protected]> Co-authored-by: Wentao Ye <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]> Co-authored-by: Wentao Ye <[email protected]>
Purpose
Currently, installing DeepGEMM following install_deepgemm.sh leads to the following issue on my local H20*8 :
This issue is fixed by deepseek-ai/DeepGEMM@9c3783b. To minimize frequent DeepGEMM updates, this PR bumps DeepGEMM to latest commit.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.