Skip to content

Conversation

Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented Sep 3, 2025

Purpose

  • Clean up some dead code for legacy pipeline

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Isotr0py <[email protected]>
@mergify mergify bot added the multi-modality Related to multi-modality (#4194) label Sep 3, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) September 3, 2025 06:23
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request provides a cleanup of dead code related to a legacy processing pipeline. The changes include removing a workaround for empty multimodal inputs in a deprecated utility function, replacing it with an AssertionError to ensure the path is no longer taken. Additionally, a previously skipped test for an InternVL model is re-enabled, which is consistent with the removal of the legacy pipeline. The changes are well-contained and improve the overall health of the codebase.

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 3, 2025
@DarkLight1337 DarkLight1337 merged commit 9c99e48 into vllm-project:main Sep 3, 2025
46 of 48 checks passed
@Isotr0py Isotr0py deleted the cleanup-deadcode branch September 3, 2025 08:46
eicherseiji pushed a commit to eicherseiji/vllm that referenced this pull request Sep 9, 2025
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants