Skip to content

Conversation

gfinol
Copy link
Contributor

@gfinol gfinol commented Sep 17, 2025

Purpose

This PR adds the "path" option to data_format in ImagePrompt for the prithvi_io_processor plugin.

Notice that the plugin already supports that option, but fails when used with a file because of the pydantic check.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • [ x] The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors.

You ask your reviewers to trigger select CI tests on top of fastcheck CI.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the path option for data_format in the ImagePrompt model, allowing local file paths to be used as image inputs for the prithvi_io_processor plugin. The change itself is correct, but it lacks corresponding tests to validate the new functionality. Additionally, I've identified a pre-existing issue with the bytes data format option on the same line, which appears to be non-functional. I've added comments with suggestions to address both points to improve the robustness and correctness of the plugin.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While this change correctly adds the path option to data_format, the new functionality is not covered by any tests. To ensure correctness and prevent future regressions, please add a test case for data_format: "path" in tests/plugins_tests/test_io_processor_plugins.py. You could add a new test function or parameterize an existing one to handle the path case, for example by downloading the test image to a temporary file and passing its path.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The "bytes" option in data_format appears to be non-functional. The load_image function in prithvi_processor.py expects a list of strings, but for data_format="bytes" it would receive a list containing a bytes object. The logic to handle bytes data within load_image is commented out, and read_geotiff is not called correctly for this case. This will lead to a runtime error. Since you are modifying this line, it would be beneficial to either fix the implementation for "bytes" or remove it from the Literal to avoid confusion.

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @christian-pinto can you review this?

@christian-pinto
Copy link
Contributor

Sure

Copy link
Contributor

@christian-pinto christian-pinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great catch

@vllm-bot vllm-bot merged commit aa3f105 into vllm-project:main Sep 18, 2025
15 checks passed
debroy-rh pushed a commit to debroy-rh/vllm that referenced this pull request Sep 19, 2025
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
charlifu pushed a commit to ROCm/vllm that referenced this pull request Sep 25, 2025
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
choprahetarth pushed a commit to Tandemn-Labs/vllm that referenced this pull request Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants