Skip to content

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented Sep 18, 2025

Part of #18953

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the codebase by moving the StructuredOutputsConfig class and its related StructuredOutputsBackend type alias from vllm/config/__init__.py to a new, dedicated file vllm/config/structured_outputs.py. This change improves code organization and modularity by placing the structured outputs configuration in its own module. The necessary imports have been updated accordingly. The changes are correct and represent a good improvement to the project structure.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) September 18, 2025 09:27
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 18, 2025
@DarkLight1337 DarkLight1337 merged commit 8ed039d into vllm-project:main Sep 18, 2025
44 of 45 checks passed
@hmellor hmellor deleted the extract-structured-outputs-config branch September 18, 2025 11:53
debroy-rh pushed a commit to debroy-rh/vllm that referenced this pull request Sep 19, 2025
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
charlifu pushed a commit to ROCm/vllm that referenced this pull request Sep 25, 2025
…tructured_outputs.py` (vllm-project#25153)

Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: charlifu <[email protected]>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
…tructured_outputs.py` (vllm-project#25153)

Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: xuebwang-amd <[email protected]>
choprahetarth pushed a commit to Tandemn-Labs/vllm that referenced this pull request Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants