-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[Docs] Fix warnings in mkdocs build (continued) #25163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WARNING - mkdocs_autorefs: api/vllm/entrypoints/openai/serving_engine.md: from /Users/zerohertz/Downloads/opensources/vllm/vllm/entrypoints/openai/serving_engine.py:699: (vllm.entrypoints.openai.serving_engine.OpenAIServing._tokenize_prompt_input_async) Could not find cross-reference target 'vllm.entrypoints.openai.serving_engine.OpenAIServing._tokenize_prompt_input_or_inputs' WARNING - mkdocs_autorefs: api/vllm/entrypoints/openai/serving_engine.md: from /Users/zerohertz/Downloads/opensources/vllm/vllm/entrypoints/openai/serving_engine.py:720: (vllm.entrypoints.openai.serving_engine.OpenAIServing._tokenize_prompt_inputs_async) Could not find cross-reference target 'vllm.entrypoints.openai.serving_engine.OpenAIServing._tokenize_prompt_input_or_inputs' Signed-off-by: Zerohertz <[email protected]>
WARNING - griffe: vllm/distributed/device_communicators/shm_object_storage.py:255: Failed to get 'name: description' pair from 'frees the maximum size of the ring buffer.' Signed-off-by: Zerohertz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses several documentation build warnings. The changes include fixing a docstring format issue in vllm/distributed/device_communicators/shm_object_storage.py
by adding correct indentation, and removing broken cross-references in docstrings within vllm/entrypoints/openai/serving_engine.py
. These changes are straightforward, correct, and effectively resolve the specified warnings, improving the overall quality of the documentation. The code modifications are well-contained and do not introduce any functional changes or issues. The pull request is good to merge.
Signed-off-by: Zerohertz <[email protected]>
Signed-off-by: Zerohertz <[email protected]>
Signed-off-by: Zerohertz <[email protected]> Signed-off-by: charlifu <[email protected]>
Signed-off-by: Zerohertz <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
Signed-off-by: Zerohertz <[email protected]>
Continued #23649, #23743, #24092, #24740, #24791
Related: #25020
Note
Warnings fixed: