-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
allow disable flashinfer prefill #25276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@luccafong has exported this pull request. If you are a Meta employee, you can view the originating diff in D81994905. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new environment variable, VLLM_DISABLE_FLASHINFER_PREFILL
, to provide an option to disable FlashInfer prefill. This change addresses a compatibility issue on GB200 with CutlassMLA FP8. The implementation adds the new flag in vllm/envs.py
and correctly uses it in vllm/v1/attention/backends/mla/common.py
to control the feature. The default behavior is unchanged. The changes are correct and well-contained.
Summary: GB200 FlashInfer Prefill is not compatible with CutlassMLA FP8, allowing disable it for now. Differential Revision: D81994905 Signed-off-by: Lu Fang <[email protected]>
cc162ce
to
95df807
Compare
Seems reasonable for now, thanks |
Signed-off-by: Lu Fang <[email protected]>
Signed-off-by: Lu Fang <[email protected]> Signed-off-by: charlifu <[email protected]>
Signed-off-by: Lu Fang <[email protected]> Signed-off-by: yewentao256 <[email protected]>
Signed-off-by: Lu Fang <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
Signed-off-by: Lu Fang <[email protected]>
Summary: GB200 FlashInfer Prefill is not compatible with CutlassMLA FP8, allowing disable it for now.
Differential Revision: D81994905