-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
optimize: eliminate duplicate split_enc_dec_inputs calls #25573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: eliminate duplicate split_enc_dec_inputs calls #25573
Conversation
This pull request has merge conflicts that must be resolved before it can be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the code to eliminate duplicate calls to split_enc_dec_inputs
in llm_engine.py
and processor.py
. By calling split_enc_dec_inputs
once and passing the results to _validate_model_inputs
, the change improves performance by reducing redundant work. The implementation is correct and maintains the existing validation logic. I have reviewed the changes and found no issues.
86ef49f
to
30548d4
Compare
Signed-off-by: nicole-lihui <[email protected]>
30548d4
to
723d780
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for simplifying!
Signed-off-by: nicole-lihui <[email protected]> Signed-off-by: yewentao256 <[email protected]>
…t#25573) Signed-off-by: nicole-lihui <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
…t#25573) Signed-off-by: nicole-lihui <[email protected]>
Purpose
eliminate duplicate split_enc_dec_inputs calls
This improves performance by
reducing redundant function calls while maintaining the same validation logic.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.