Skip to content

Conversation

fadara01
Copy link
Contributor

@fadara01 fadara01 commented Sep 24, 2025

[fix] Update torch version in cpu-build.txt for AArch64/ppc64le and Darwin

Purpose

Update torch version in cpu-build.txt to match that in cpu.txt
This fixes AArch64 build failures: #25578

Test Plan

pip install -r vllm/requirements/cpu-build.txt
VLLM_TARGET_DEVICE=cpu python3 setup.py bdist_wheel

Test Result

Build Passes on AArch64, before this it used to fail, see #25578


Essential Elements of an Effective PR Description Checklist
  • [Y] The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • [N/A] The test plan, such as providing test command.
  • [Y] The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors.

You ask your reviewers to trigger select CI tests on top of fastcheck CI.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

🚀

@mergify mergify bot added the ci/build label Sep 24, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the torch version for AArch64 in requirements/cpu-build.txt to fix a build failure. While the change correctly addresses the issue for AArch64, it introduces a regression by removing the torch dependency for other platforms like macOS (Darwin). My review includes a suggestion to add back the torch dependency for Darwin to ensure build compatibility across all supported platforms.

@fadara01 fadara01 changed the title [fix] Update torch version in cpu-build.txt for AArch64 [fix] Update torch version in cpu-build.txt for AArch64/ppc64le and Darwin Sep 24, 2025
@fadara01 fadara01 force-pushed the update_aarch64_torch_version branch from f264bb5 to eb930b5 Compare September 24, 2025 11:20
@fadara01
Copy link
Contributor Author

cc: @nikhil-arm

This now matches the torch version for AArch64 in cpu.txt

Fixes: vllm-project#25578
Signed-off-by: Fadi Arafeh <[email protected]>
@fadara01 fadara01 force-pushed the update_aarch64_torch_version branch from 7935119 to 35583da Compare September 24, 2025 17:14
@mgoin mgoin enabled auto-merge (squash) September 24, 2025 23:36
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 24, 2025
@mgoin mgoin merged commit 393de22 into vllm-project:main Sep 25, 2025
16 checks passed
Zhuul pushed a commit to Zhuul/vllm that referenced this pull request Sep 26, 2025
yewentao256 pushed a commit that referenced this pull request Oct 3, 2025
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
choprahetarth pushed a commit to Tandemn-Labs/vllm that referenced this pull request Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants