-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[fix] Update torch version in cpu-build.txt for AArch64/ppc64le and Darwin #25579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Update torch version in cpu-build.txt for AArch64/ppc64le and Darwin #25579
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the torch version for AArch64 in requirements/cpu-build.txt
to fix a build failure. While the change correctly addresses the issue for AArch64, it introduces a regression by removing the torch dependency for other platforms like macOS (Darwin). My review includes a suggestion to add back the torch dependency for Darwin to ensure build compatibility across all supported platforms.
f264bb5
to
eb930b5
Compare
cc: @nikhil-arm |
This now matches the torch version for AArch64 in cpu.txt Fixes: vllm-project#25578 Signed-off-by: Fadi Arafeh <[email protected]>
7935119
to
35583da
Compare
…arwin (vllm-project#25579) Signed-off-by: Fadi Arafeh <[email protected]>
…arwin (#25579) Signed-off-by: Fadi Arafeh <[email protected]> Signed-off-by: yewentao256 <[email protected]>
…arwin (vllm-project#25579) Signed-off-by: Fadi Arafeh <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
…arwin (vllm-project#25579) Signed-off-by: Fadi Arafeh <[email protected]>
[fix] Update torch version in cpu-build.txt for AArch64/ppc64le and Darwin
Purpose
Update torch version in cpu-build.txt to match that in cpu.txt
This fixes AArch64 build failures: #25578
Test Plan
Test Result
Build Passes on AArch64, before this it used to fail, see #25578
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.