Skip to content

[torch.compile] Adding torch compile annotations to some models #9614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 23, 2024
Merged

[torch.compile] Adding torch compile annotations to some models #9614

merged 3 commits into from
Oct 23, 2024

Conversation

CRZbulabula
Copy link
Contributor

This PR is to improve #9589, adding annotations and testing them.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@CRZbulabula CRZbulabula marked this pull request as draft October 23, 2024 13:26
@youkaichao youkaichao marked this pull request as ready for review October 23, 2024 15:39
youkaichao
youkaichao approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@youkaichao youkaichao merged commit 9013e24 into vllm-project:main Oct 23, 2024
31 of 32 checks passed
@CRZbulabula CRZbulabula deleted the support-some-torch-compile branch October 24, 2024 00:45
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@CRZbulabula @Alvant
[torch.compile] Adding torch compile annotations to some models (vllm…
358a773 
…-project#9614)

Signed-off-by: Alvant <[email protected]>
MErkinSag pushed a commit to MErkinSag/vllm that referenced this pull request Oct 26, 2024
@CRZbulabula
[torch.compile] Adding torch compile annotations to some models (vllm…
70d7f23 
…-project#9614)

Signed-off-by: Erkin Sagiroglu <[email protected]>
FerdinandZhong pushed a commit to FerdinandZhong/vllm that referenced this pull request Oct 29, 2024
@CRZbulabula @FerdinandZhong
[torch.compile] Adding torch compile annotations to some models (vllm…
7687cea 
…-project#9614)

Signed-off-by: qishuai <[email protected]>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
@CRZbulabula @sumitd2
[torch.compile] Adding torch compile annotations to some models (vllm…
a853eff 
…-project#9614)

Signed-off-by: Sumit Dubey <[email protected]>
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
@CRZbulabula @LeiWang1999
[torch.compile] Adding torch compile annotations to some models (vllm…
663bb59 
…-project#9614)

Signed-off-by: LeiWang1999 <[email protected]>
@llsj14
Copy link
Contributor

llsj14 commented Jun 5, 2025

@CRZbulabula @youkaichao
Hi, I’m wondering if there are any models where torch.compile cannot be applied, like in this PR. Also, how can I check if this change works correctly? Could you give me some advice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youkaichao youkaichao youkaichao approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CRZbulabula @llsj14 @youkaichao