Skip to content

Conversation

@puppylpg
Copy link
Contributor

Use jquery locally, in case that jquery is unreachable in some places.

@vsoch
Copy link
Owner

vsoch commented Aug 30, 2020

Thank you @puppylpg ! I'm guessing you are adding the minified version for easy reference, although it's not included in the site. I'm happy to do this, and have tested the pull request locally and it works as expected!

@vsoch vsoch self-requested a review August 30, 2020 16:04
Copy link
Owner

@vsoch vsoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @puppylpg !

@vsoch vsoch merged commit 0878832 into vsoch:master Aug 30, 2020
@puppylpg
Copy link
Contributor Author

Thank you @puppylpg ! Is there any reason to add the full version if we only use the minified one?

Just beacause that're all the files jquery has. I don't know if the full version will be used in the long run, so adding both of them may be the best way to extend. Besides, I do think both of the files are small enough when requesting.

@puppylpg
Copy link
Contributor Author

Thank you for your contribution @puppylpg !

It's me who should say thanks. I really enjoy this template, making my static website much more convenient to use. Glod to do some small contribution for you~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants