Skip to content

If no fallback slot is provided, no blank should be displayed if possible when timeout is specified #3986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
posva opened this issue Jun 21, 2021 · 0 comments · May be fixed by #3991
Open

If no fallback slot is provided, no blank should be displayed if possible when timeout is specified #3986

posva opened this issue Jun 21, 2021 · 0 comments · May be fixed by #3991
Labels
need guidance The approach/solution in the PR is unclear and requires guidance from maintainer to proceed further. scope: suspense ✨ feature request New feature or request

Comments

@posva
Copy link
Member

posva commented Jun 21, 2021

Version

3.1.1

Reproduction link

Playground

Steps to reproduce

  • Check the checkbox

What is expected?

  • Other content to be replaced by Parent after 1s

What is actually happening?

  • After 500ms (the timeout), nothing is displayed
  • After 1s, Parent is displayed

I think this default would make more sense and could be easily replaced with the existing behavior by providing an empty fallback slot
@posva posva added need guidance The approach/solution in the PR is unclear and requires guidance from maintainer to proceed further. scope: suspense ✨ feature request New feature or request labels Jun 21, 2021
@posva posva changed the title If no fallback slot is provided, no blank should be displayed if possible If no fallback slot is provided, no blank should be displayed if possible when timeout is specified Jun 22, 2021
posva added a commit that referenced this issue Jun 22, 2021
@posva
fix(suspense): display current branch if no fallback is provided
8de0372 
Fix #3986
@posva posva linked a pull request Jun 23, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
need guidance The approach/solution in the PR is unclear and requires guidance from maintainer to proceed further. scope: suspense ✨ feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(suspense): display current branch if no fallback is provided vuejs/core
1 participant
@posva