Skip to content

fix(Suspense): skip patch nested suspense if parent suspense is not resolved #10055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 11, 2024
Merged

fix(Suspense): skip patch nested suspense if parent suspense is not resolved #10055

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ebc9d9f
fix(Suspense): avoid patch nested suspense with suspensible true
edison1105 Jan 9, 2024
7e59a62
test: chore test case
edison1105 Jan 9, 2024
96bec97
fix(Suspense): avoid unmont nested suspense with suspensible true if …
edison1105 Jan 9, 2024
ca3dd2e
chore: improve code
edison1105 Jan 10, 2024
7f19cd0
revert
edison1105 Jan 10, 2024
566dfbe
Merge branch 'main' into fix/8678
edison1105 Jan 10, 2024
3d9ff34
chore: add comments
edison1105 Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(Suspense): avoid unmont nested suspense with suspensible true if … 
…parent suspense is not resolved
  • Loading branch information
@edison1105
edison1105 committed Jan 9, 2024
commit 96bec973f1c972785d71ec62c627c6c16ca2422f
3 changes: 3 additions & 0 deletions packages/runtime-core/src/components/Suspense.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,6 +720,9 @@ function createSuspenseBoundary(
},

unmount(parentSuspense, doRemove) {
if (isVNodeSuspensible(suspense.vnode) && parentSuspense?.deps !== 0) {
return
}
suspense.isUnmounted = true
if (suspense.activeBranch) {
unmount(
Expand Down