Skip to content

refactor(shared): replace switch with config in escapeHtml #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

refactor(shared): replace switch with config in escapeHtml #1101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 17 additions & 25 deletions packages/shared/src/escapeHtml.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,33 +12,25 @@ export function escapeHtml(string: unknown) {
let escaped: string
let index: number
let lastIndex = 0
const codeToEscapes:any = {
34:'"', // "
38:'&', // &
39:''', // '
60:'&lt;', // <
62:'&gt;' // >
}
for (index = match.index; index < str.length; index++) {
switch (str.charCodeAt(index)) {
case 34: // "
escaped = '&quot;'
break
case 38: // &
escaped = '&amp;'
break
case 39: // '
escaped = '&#39;'
break
case 60: // <
escaped = '&lt;'
break
case 62: // >
escaped = '&gt;'
break
default:
continue
}

if (lastIndex !== index) {
html += str.substring(lastIndex, index)
const code = str.charCodeAt(index)

if(codeToEscapes[code]){
escaped = codeToEscapes[code]
if (lastIndex !== index) {
html += str.substring(lastIndex, index)
}

lastIndex = index + 1
html += escaped
}

lastIndex = index + 1
html += escaped
}

return lastIndex !== index ? html + str.substring(lastIndex, index) : html
Expand Down