feat(compiler-core,v-model): create transform for v-model #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znck
changed the title
yyx990803
requested changes
Oct 10, 2019
pikax
reviewed
Oct 10, 2019
Comment on lines
+34
to
+63
| const props = ((node.codegenNode as CallExpression) | ||
| .arguments[1] as ObjectExpression).properties | ||
|
|
||
| expect(props[0]).toMatchObject({ | ||
| key: { | ||
| content: 'modelValue', | ||
| isStatic: true | ||
| }, | ||
| value: { | ||
| content: 'model', | ||
| isStatic: false | ||
| } | ||
| }) | ||
|
|
||
| expect(props[1]).toMatchObject({ | ||
| key: { | ||
| content: 'onUpdate:modelValue', | ||
| isStatic: true | ||
| }, | ||
| value: { | ||
| children: [ | ||
| '$event => (', | ||
| { | ||
| content: 'model', | ||
| isStatic: false | ||
| }, | ||
| ' = $event)' | ||
| ] | ||
| } | ||
| }) |
There was a problem hiding this comment.
could this be?
expect(node.codegenNode).toMatchObject({
arguments: [
{
properties: [
{
key: {
content: "modelValue",
isStatic: true
},
value: {
content: "model",
isStatic: false
}
},
{
key: {
content: "onUpdate:modelValue",
isStatic: true
},
value: {
children: [
"$event => (",
{
content: "model",
isStatic: false
},
" = $event)"
]
}
}
]
}
]
});|
|
||
| if (isEmptyExpression(exp)) { | ||
| context.onError( | ||
| createCompilerError(ErrorCodes.X_V_MODEL_MALFORMED_EXPRESSION) |
There was a problem hiding this comment.
Should the error be empty instead of generic malformed?
There was a problem hiding this comment.
Yeah, both cases can actually be using the same error. I'll adjust this after merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on v-model RFC. The runtime handling of
onUpdate:prefixed events would be implemented in a separate PR toruntime-dom.