Skip to content

types(slots): Add typed slots #2693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

types(slots): Add typed slots #2693

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e0a1656
types(slots): Add typed slots
pikax Nov 30, 2020
b4dc05f
chore: fix tests
pikax Nov 30, 2020
53379a1
Merge branch 'upstream' into feat/typed_slots
pikax Mar 13, 2021
d729fba
chore: added support for `h`
pikax Mar 13, 2021
5300104
chore: Merge branch 'master-upstream' into feat/typed_slots
pikax Aug 20, 2021
8437736
Merge branch 'main' into feat/typed_slots
pikax Feb 20, 2023
53adc92
rollback props test implementation defineComponent test
pikax Feb 20, 2023
cc7e1c1
fix some errors
pikax Feb 20, 2023
479aaf1
improve
pikax Feb 21, 2023
3785f75
minor improvements to the type
pikax Feb 21, 2023
1fdac74
feat(compiler): added macros defineSlots
pikax Feb 21, 2023
e1eafb6
remove lingering code
pikax Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove lingering code
  • Loading branch information
@pikax
pikax committed Feb 21, 2023
commit e1eafb618e04a038b3b88be8f565222a988b20da
2 changes: 0 additions & 2 deletions packages/compiler-sfc/__tests__/compileScript.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,6 @@ const myEmit = defineEmits(['foo', 'bar'])
expect(content).toMatch(`emits: ['a'],`)
})

// ss

test('defineSlots()', () => {
const { content, bindings } = compile(`
<script setup>
Expand Down
14 changes: 0 additions & 14 deletions packages/runtime-core/src/apiDefineComponent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,17 +223,3 @@ export function defineComponent<
export function defineComponent(options: unknown) {
return isFunction(options) ? { setup: options, name: options.name } : options
}

defineComponent({
slots: null as unknown as {
item: {
value: string
}
},

setup(_, { slots }) {
slots.item?.({
value: '1'
})
}
})