feat(compiler-core): only using get instead has and get to get cached components
#314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyx990803
requested changes
Oct 16, 2019
|
Hey @pikax, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
jackiecookie
added a commit
to jackiecookie/vue-next
that referenced
this pull request
Oct 18, 2019
* chore: Remove unnecessary console.log (vuejs#312) * types: improve typing (vuejs#313) * types: improve typing (vuejs#309) * perf(v-for): use faster array population in renderList * refactor(compiler-core): avoid has call (vuejs#314) * feat(compiler-core): do not generate TEXT flag if child is constant * perf(runtime-core): use faster diff map population (vuejs#319) * feat(compiler-core/v-model): avoid patching v-model handler when possible * feat(compiler-core/v-model): error when v-model is used on scope variable * feat(compiler-core/v-model): generate modelModifiers for component v-model * feat(compiler-core/v-slot): only force dynamic slots when referencing scope vars This feature is only applied with prefixIdentifiers: true. * perf: skip hasScopeRef check if there are no scope vars * build(deps-dev): bump lerna from 3.18.0 to 3.18.1 Bumps [lerna](https://github.com/lerna/lerna/tree/HEAD/core/lerna) from 3.18.0 to 3.18.1. - [Release notes](https://github.com/lerna/lerna/releases) - [Changelog](https://github.com/lerna/lerna/blob/master/core/lerna/CHANGELOG.md) - [Commits](https://github.com/lerna/lerna/commits/v3.18.1/core/lerna) Signed-off-by: dependabot-preview[bot] <[email protected]> * feat: emit compiler error for invalid JavaScript expressions * feat(compiler-core): support Suspense in templates * fix(runtime-core): handle dynamicChildren when portal is used as a block * chore: typos [ci-skip] (vuejs#323) * perf: revert to _isRef for perf Benchmarking shows checking for a plain property is about 4~5x faster than checking for a Symbol, likely because the Symbol does not fit well into V8's hidden class model. * perf(core): cache property access types on renderProxy * perf: minor tweaks * test(compiler-core): add test for custom delimiter (vuejs#315) * refactor(runtime-core): extract promise check into shared (vuejs#325) * perf: further tweak accessCache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
benchmarking shows a slight improvement when the cache contains the value and same performance on negative