chore: comments

packages/compiler-core/src/codegen.ts

@@ -776,7 +776,7 @@ function genVNodeCall(node: VNodeCall, context: CodegenContext) {
     push(PURE_ANNOTATION)
   }
   let callHelper: symbol = isBlock ? CREATE_BLOCK : CREATE_VNODE
-  if (!context.ssr) {
+  if (!context.forSSR) {
     callHelper = isBlock
       ? isComponent
         ? CREATE_COMPONENT_BLOCK
@@ -793,7 +793,7 @@ function genVNodeCall(node: VNodeCall, context: CodegenContext) {
       children,
       patchFlag,
       dynamicProps,
-      context.ssr ? null : shapeFlag
+      context.forSSR ? null : shapeFlag
     ]),
     context
   )

packages/compiler-core/src/transform.ts

@@ -356,15 +356,15 @@ function createRootCodegen(root: RootNode, context: TransformContext) {
         if (!codegenNode.isBlock) {
           codegenNode.isBlock = true
           removeHelper(
-            context.ssr
+            context.forSSR
               ? CREATE_VNODE
               : codegenNode.isComponent
                 ? CREATE_COMPONENT_VNODE
                 : CREATE_ELEMENT_VNODE
           )
           helper(OPEN_BLOCK)
           helper(
-            context.ssr
+            context.forSSR
               ? CREATE_BLOCK
               : codegenNode.isComponent
                 ? CREATE_COMPONENT_BLOCK

packages/compiler-core/src/transforms/hoistStatic.ts

@@ -238,7 +238,7 @@ export function getConstantType(
           )
           codegenNode.isBlock = false
           context.helper(
-            context.ssr
+            context.forSSR
               ? CREATE_VNODE
               : codegenNode.isComponent
                 ? CREATE_COMPONENT_VNODE
@@ -288,7 +288,7 @@ export function getConstantType(
   }
 }
 
-const allowHoistedHelperSet = new Set<string | symbol>([
+const allowHoistedHelperSet = new Set([
   NORMALIZE_CLASS,
   NORMALIZE_STYLE,
   NORMALIZE_PROPS,
@@ -303,13 +303,14 @@ function getConstantTypeOfHelperCall(
 ): ConstantTypes {
   if (
     value.type === NodeTypes.JS_CALL_EXPRESSION &&
+    !isString(value.callee) &&
     allowHoistedHelperSet.has(value.callee)
   ) {
     const arg = value.arguments[0] as JSChildNode
     if (arg.type === NodeTypes.SIMPLE_EXPRESSION) {
       return getConstantType(arg, context)
     } else if (arg.type === NodeTypes.JS_CALL_EXPRESSION) {
-      // in the case of nested calls, e.g. `normalizeProps(guardReactiveProps(exp))`
+      // in the case of nested helper call, e.g. `normalizeProps(guardReactiveProps(exp))`
       return getConstantTypeOfHelperCall(arg, context)
     }
   }
@@ -334,9 +335,9 @@ function getGeneratedPropsConstantType(
         returnType = keyType
       }
       if (value.type !== NodeTypes.SIMPLE_EXPRESSION) {
-        // some function calls can be hoisted,
-        // such as the `normalizeClass` call generated by the compiler for pre-normalize class,
-        // in this case we need to respect the ConstanType of the function's argments
+        // some helper calls can be hoisted,
+        // such as the `normalizeProps` generated by the compiler for pre-normalize class,
+        // in this case we need to respect the ConstanType of the helper's argments
         if (value.type === NodeTypes.JS_CALL_EXPRESSION) {
           return getConstantTypeOfHelperCall(value, context)
         }

packages/compiler-core/src/transforms/transformElement.ts

@@ -204,6 +204,7 @@ export const transformElement: NodeTransform = (node, context) => {
           shapeFlag |= ShapeFlags.TEXT_CHILDREN
         } else {
           vnodeChildren = node.children
+          // KeepAlive is a component, but no slot is built for it at compile time
           vnodeTag !== KEEP_ALIVE && (shapeFlag |= ShapeFlags.ARRAY_CHILDREN)
         }
       } else {
@@ -446,6 +447,7 @@ export function buildProps(
         dynamicPropNames.push(name)
       }
 
+      // treat the dynamic binding class and style of the component as dynamic props
       if (
         isComponent &&
         (name === 'class' || name === 'style') &&
@@ -690,7 +692,7 @@ export function buildProps(
     patchFlag |= PatchFlags.NEED_PATCH
   }
 
-  // pre-normalize props, SSR skip for now
+  // pre-normalize props, SSR is skipped for now
   if (!context.forSSR && propsExpression) {
     switch (propsExpression.type) {
       case NodeTypes.JS_OBJECT_EXPRESSION:
@@ -786,8 +788,8 @@ export function buildProps(
   }
 }
 
-// normalization is only needed when the dynamic binding key is before the binding of class and style
-// i.e. <p :[dynamic]="val" :class="cls" :style="stl" />
+// normalization is only needed when the dynamic binding key is before the class and style
+// e.g. <p :[dynamic]="val" :class="cls" :style="stl" />
 function doNormalize(
   context: TransformContext,
   properties: Property[],

packages/compiler-core/src/utils.ts

@@ -329,9 +329,9 @@ export function injectProp(
       createObjectExpression([prop]),
       props
     ])
-    // in the case of `normalizeProps(guardReactiveProps(props))`,
-    // will be rewritten as `normalizeProps(mergeProps({ key: 0 }, props))`,
-    // `guardReactiveProps` will no longer be needed
+    // in the case of nested helper call, e.g. `normalizeProps(guardReactiveProps(props))`,
+    // it will be rewritten as `normalizeProps(mergeProps({ key: 0 }, props))`,
+    // the `guardReactiveProps` will no longer be needed
     if (parentCall && parentCall.callee === GUARD_REACTIVE_PROPS) {
       parentCall = callPath[callPath.length - 2]
     }

packages/runtime-core/src/vnode.ts

@@ -589,9 +589,7 @@ function _createVNode(
   // class & style normalization.
   if (props) {
     // for reactive or proxy objects, we need to clone it to enable mutation.
-    if (isProxy(props) || InternalObjectKey in props) {
-      props = extend({}, props)
-    }
+    props = guardReactiveProps(props)!
     let { class: klass, style } = props
     if (klass && !isString(klass)) {
       props.class = normalizeClass(klass)