-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Tutorial lessons 1-7 #1378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial lessons 1-7 #1378
Conversation
✔️ Deploy Preview for vue-docs-preview ready! 🔨 Explore the source changes: e62aa91 🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-docs-preview/deploys/61d82e413893cc000757cbc3 😎 Browse the preview: https://deploy-preview-1378--vue-docs-preview.netlify.app |
<input type="number" :value="colorsNumber" /> | ||
``` | ||
|
||
However, when we change the number in the input field, we don't see any changes on `Number of colors` in the template 🤔. It happens because we only have _one-way binding_ now, displaying reactive property in the input field but not _changing_ it on user input. Let's listen to the `input` DOM event on the `<input>` field and update `colorsNumber` on it: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like readers would benefit from being able to see the broken behaviour mentioned in the first sentence for themselves. Update: I thought about this a bit more. Is the intention that people will be writing code at the same time as reading this? I suspect most people will just be reading along and won't go to the effort of writing any code themselves while they're reading. They might tweak tiny bits in the REPL, but that's about it.
Off the top of my head, I'm wondering whether step 2 should just focus on introducing v-bind
, while events and v-model
could be moved to a separate step?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skirtles-code yes, the idea of the tutorial is to let people code on REPL. I am not really sure how we could encourage them to code rather than read only 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding separating v-bind
and events + v-model: this sounds like a good idea 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Split lessons to bite-sized chunks
a0005a0
to
fa88672
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Incredible job @NataliaTepluhina. So excited for the world to see your amazing work on this! 🥳 |
627d35b
to
80045f2
Compare
30f506c
to
4b626e8
Compare
@yyx990803 after a brief discussion with docs team we decided to split lessons onto as little chunks as possible so users wouldn't need to read the whole story to finish a particular lesson. Could you please take a look at the new structure? |
002d501
to
0ac587d
Compare
0ac587d
to
e62aa91
Compare
This PR adds first three lessons to the tutorial. I've implemented also a mechanism to showing the final code of the lesson and switching back to the code user already typed