Composition API version #2075
Composition API version #2075
Conversation
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
skirtles-code
left a comment
skirtles-code
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I've provided some feedback below. In my opinion, introducing a Composition API version of the first example should be fine, but I don't think we can change the second example. More details below.
src/guide/scaling-up/sfc.md
Outdated
| import { ref } from 'vue'; | ||
| const greeting = ref('Hello World!'); | ||
| } |
There was a problem hiding this comment.
I suggest removing the indent, the semicolons, and the trailing }:
| import { ref } from 'vue'; | |
| const greeting = ref('Hello World!'); | |
| } | |
| import { ref } from 'vue' | |
| const greeting = ref('Hello World!') |
src/guide/scaling-up/sfc.md
Outdated
|
|
||
| ```js | ||
| import MyComponent from './MyComponent.vue' | ||
| <div class="options-api"> |
There was a problem hiding this comment.
I don't think we should change this second example. The current example is intended to show importing a .vue file into a plain .js file. It's supposed to illustrate how .vue files are just ES modules. Showing a .vue importing a .vue doesn't quite make the same point about compatibility with normal JavaScript.
The existing example is valid for both the Options API and the Composition API. The components option is common to both.
|
This PR is superseded by #2145. The commits from this PR are included in that PR. |
2 participants
Description of Problem
Some code examples were missing the composition API/options API variant, toggle button was not switching between the two variants.
Proposed Solution
Added missing Composition API examples.
Additional Information