Skip to content

Images and styling for One-time Donation buttons #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

skirtles-code
Copy link
Contributor

Closes #739.

The One-time Donation buttons weren't working correctly.

  • I've copied the QR code images across from the Vue 2 docs.
  • There was a bug with the hashchange listener (incorrect this binding). I've refactored to use a method.
  • color: $medium wasn't working. Based on how these were styled in the Vue 2 docs, I decided to go for consistency with the sidebar links.

I don't have a device that can check the QR code images, so I'm relying on what was in Vue 2 being correct.

@NataliaTepluhina NataliaTepluhina merged commit 3358c48 into vuejs:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sponser page's one time donations section is not working
2 participants