Skip to content

Document non-fixable rules correctly #2343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 27, 2023
Merged

Document non-fixable rules correctly #2343

merged 3 commits into from
Dec 27, 2023

Conversation

FloEdelmann
Copy link
Member

This PR enables the catchNoFixerButFixableProperty rule option of the eslint-plugin/require-meta-fixable rule, which increases the number of false-positives, but also catches two non-fixable rules that were incorrectly described.

@FloEdelmann FloEdelmann added documentation meta Code style improvements, build process improvements, refactorings labels Dec 4, 2023
@FloEdelmann FloEdelmann requested a review from ota-meshi December 4, 2023 16:06
@FloEdelmann FloEdelmann mentioned this pull request Dec 4, 2023
Merged
ota-meshi
ota-meshi approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ota-meshi ota-meshi merged commit 7cf5c51 into master Dec 27, 2023
@ota-meshi ota-meshi deleted the fixable branch December 27, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
documentation meta Code style improvements, build process improvements, refactorings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FloEdelmann @ota-meshi