-
-
Notifications
You must be signed in to change notification settings - Fork 438
v3.0 Preview #5261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Amazing work. Is there webstorm build? Not sure does it even possible. |
@Satont I think that's promising, @tomblachut has already confirmed the required adjustments! |
I see you've made some changes to language service plugins here. Would you be able to support working with custom language service plugins in v3? I mean reintroduce changes from #1028 to make volar/services work again? |
@Ilanaya LS plugin support is part of the 3.0 plan, but will not be supported via the reintroduction of volar.config.js. |
I just tested 3.0.0-alpha.2, and it looks pretty good. I found no bugs so far. |
何时发布3.0版本 |
@spaceemotion please provide a minimal reproduction. |
Tried out alpha 2 with VSCode Remote Development (over SSH), but it seems to often cause the connection to close. It seems to reliably trigger when I go to view the extensions pane, but I've seen it happen seemingly at random too. I tried checking the logs on the remote, but all I could find was this:
Here Using VSCode v1.98.2 and Remote SSH v0.118.0 (both the latest as of right now), a Windows host and a Linux remote (but it seems to be the remote that crashes). |
that sounds awesome.. roughly when can we expect a release in VS market place? :) |
Since semver pre-release tags are not supported on VSCode, we can't release these alpha versions at the moment. Before the official version is released, we need to patiently wait for other editors to integrate the new architecture. |
So basically waiting for Jetbrains here to adjust their plugin API, ok |
It doesn't matter which project i open, with alpha 6 the tsserver is crashing immediately:
|
Sorry, I have updated the vsix link. |
Might have issues with Yarn... Downgraded to 2.2.10 and it works again.
|
Having the same issue with @spaceemotion, the completion items for a vue components only show 4 default entries: However if I manually type the prop/event, it can refer to the correct type, diagnostic for required props also works fine. This issue happens from 'alpha 0'. Is it used some new 'feature' in LSP that require the LSP client to adopt? Btw tried the vscode version, all work as excepted. |
v3.0 redesigned the communication method with tsserver #5252. |
I see, I think the issue is here:https://github.com/vuejs/language-tools/pull/5252/files#diff-3c2b2dc57146f5d52dc996ede798d28b5e6163dcd75762900a25803398a099edR89-R102 There's no There should be a way to do it in neovim (I will play with it when i have time), but regardless to me this change limited the version 3 to work with vscode only.🤔 Not as in other editors cannot make it work but it requires more effort from the user. |
@RayGuo-ergou "forwardingTsRequest" (now changed to "tsserverRequest") is not specific to VSCode. It is a command ID set by the language client, and the language server sends a forwarding request to the language client based on the command ID. (See: https://github.com/search?q=repo%3Avuejs%2Flanguage-tools%20tsserverRequest&type=code) For other IDEs, what needs to be explored is how the Vue language client accesses the tsserver process so that the Vue language client can forward requests from the Vue language server to tsserver. In VSCode the tsserver process is maintained by the built-in TS extension, and we use a hack to access it. |
Thanks for clarifying. Sorry did not make that clear, yeah I did mean there's a new custom command that the editors has to handle in some level. What I mean by 'work with vscode only' is that only the vscode plugin comes out of box with vue lsp. But if there's a strong reason to do it in this way (i think there is: named pipe), should be fine as long as it properly documented.
I would imagine there's still work to do to achieve this in neovim I will let you know how i goes so there would not be a ton of issues after release 😄 update: Got something so for neovim users at least have to add these settings while setup lsp I will try to make it complete and create a PR to update the readme |
3.0.0-alpha.0 (2025-03-08)
3.0.0-alpha.2 (2025-03-17)
3.0.0-alpha.4 (2025-04-08)
3.0.0-alpha.6 (2025-05-05)
The text was updated successfully, but these errors were encountered: