Skip to content

fix(ci): Run auto-fix from the correct branch #5309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2025

Conversation

AaronDewes
Copy link
Contributor

By default, pull_request_target checks out the main branch of vuejs/language-tools and runs the auto fix there. This is very likely not what you wanted to achive.

Also, the permissions pull_request_target has are very broad and can be dangerous.

By default, `pull_request_target` checks out the main branch of vuejs/language-tools and runs the auto fix there. This is very likely not what you wanted to achive.

Also, the permissions pull_request_target has are very broad and can be dangerous.
@AaronDewes AaronDewes changed the title fix: Run auto-fix from the correct branch fix(ci): Run auto-fix from the correct branch Apr 9, 2025
Copy link

pkg-pr-new bot commented Apr 9, 2025

Open in StackBlitz

vue-component-meta

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-meta@5309

vue-component-type-helpers

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@5309

@vue/language-plugin-pug

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@5309

@vue/language-server

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-server@5309

@vue/language-core

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-core@5309

@vue/language-service

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-service@5309

vue-tsc

npm i https://pkg.pr.new/vuejs/language-tools/vue-tsc@5309

@vue/typescript-plugin

npm i https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@5309

commit: b6c1725

Just to check if this actually does anything
@AaronDewes
Copy link
Contributor Author

AaronDewes commented Apr 9, 2025

As you can see from this PR,

the job running on pull_request_target did not pick up anything. Meanwhile, the new job should up the "mistake" and fix it (it's still queued right now)


Hmm, it still does not work 🤔 But the original one did not seem to work either.

@KazariEX
Copy link
Member

I am also confused about its behavior🧐

@KazariEX
Copy link
Member

KazariEX commented Apr 10, 2025

It seems that pull_request only applies to PR from the branch of the repository itself?

@KazariEX KazariEX merged commit cdb4f5c into vuejs:master Apr 11, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants