-
-
Notifications
You must be signed in to change notification settings - Fork 438
chore(deps): replace path-browserify
with pathe
#5318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vue-component-meta
vue-component-type-helpers
@vue/language-plugin-pug
@vue/language-core
@vue/language-server
@vue/language-service
vue-tsc
@vue/typescript-plugin
commit: |
If I remember correctly, directly replacing it with |
Results or resulted? 😅
|
I plan to switch to the pnpm catalog in this PR #5174, so let's stick with the original dependency management for now. |
Thanks for your PR! But I'm going to revert this first, let me explain. We used Since |
This reverts commit 15c7115. Refs: #5318 (comment)
Stumbling across #5304 I saw that
path-browserify
could be replaced by unjspathe
.path-browserify
has not been updated for 5 years, is only commonjs and from its docs `path-browserify currently matches the Node.js 10.3 API.I used pnpm catalog to synchronise versions across the monorepo. We can replace this with the current version if needed.
We can even think about replacing
node:path
withpathe
too.All vitest tests pass.
If this PR is accepted, I can open a backport to v2.