Skip to content

docs: update changelogs for v2.2.10 #5333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 25, 2025

Conversation

Eazash
Copy link
Contributor

@Eazash Eazash commented Apr 23, 2025

While looking into the release of v2.2.10 via #5332, I noticed that the changelog file that's packaged with the extension has a link to the file from the main branch. This can cause problems as the release was off of the v2 branch, as its effectively pointing to an incorrect log. Haven't tested on the v3 extension but I think it's safe to assume it has the same issue.

This PR symlinks ./extensions/vscode/CHANGELOG.md to ./CHANGELOG.md. This means the installed extension points to the correct changelog regardless of which branch was used for release. It also has the added benefit of being able to view the changelog from within vscode.

This can cause issues for extension contributors working with windows however, as you'd need to explicitly enable symlink support with git config core.symlinks=true (reference). I believe the benefits outweigh this, but still mentioning this as it can affect future/current contributors
image

Copy link

pkg-pr-new bot commented Apr 23, 2025

Open in StackBlitz

vue-component-meta

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-meta@5333

vue-component-type-helpers

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@5333

@vue/language-plugin-pug

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@5333

@vue/language-core

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-core@5333

@vue/language-server

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-server@5333

@vue/language-service

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-service@5333

vue-tsc

npm i https://pkg.pr.new/vuejs/language-tools/vue-tsc@5333

@vue/typescript-plugin

npm i https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@5333

commit: 80267a4

@KazariEX
Copy link
Member

Thank you for bringing this up, we have decided to update change logs directly on the master branch.

@KazariEX KazariEX changed the title chore(vscode): symlink changelog file packaged with extension docs: update changelogs for v3 Apr 25, 2025
@KazariEX KazariEX changed the title docs: update changelogs for v3 docs: update changelogs for v2.2.10 Apr 25, 2025
@KazariEX KazariEX merged commit 48c4578 into vuejs:master Apr 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants