Skip to content

fix: depend on exact volar version #5345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

tomblachut
Copy link
Contributor

Patch versions of Volar are known to create incompatibilities with Vue Language Tools. This change fixes this problem for the @vue/language-server package downloaded from the npm registry.

For example something here volarjs/volar.js@v2.4.11...v2.4.12 breaks Vue Language Server 2.2.8, and npm will download the latest patch release of dependency. This doesn't show up in VSCode Extension, because Volar 2.4.11 was specified in pnpm-lock of vue-language-tools monorepo, but as far as I know it might affect all other editors.

Next I'd create similar PR for v2 branch.

Patch versions of Volar are known to create incompatibilities with Vue Language Tools. This change fixes this problem for the @vue/language-server package downloaded from the npm registry.
@tomblachut tomblachut force-pushed the lock-volar-version branch from a08120b to 485969e Compare May 1, 2025 16:25
Copy link

pkg-pr-new bot commented May 1, 2025

Open in StackBlitz

vue-component-meta

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-meta@5345

vue-component-type-helpers

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@5345

@vue/language-core

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-core@5345

@vue/language-plugin-pug

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@5345

@vue/language-server

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-server@5345

vue-tsc

npm i https://pkg.pr.new/vuejs/language-tools/vue-tsc@5345

@vue/language-service

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-service@5345

@vue/typescript-plugin

npm i https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@5345

commit: 485969e

@KazariEX KazariEX merged commit 15e4d82 into vuejs:master May 1, 2025
6 checks passed
@tomblachut tomblachut deleted the lock-volar-version branch May 1, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants