Skip to content

fix(vscode): Improved reliability of handling extension activation race #5588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 20, 2025
Merged

fix(vscode): Improved reliability of handling extension activation race #5588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f020b4
remove plaintext hack
johnsoncodehk Aug 5, 2025
dbe9678
Merge branch 'master' into remove-restartExtensionHost
johnsoncodehk Aug 20, 2025
ec7c489
Update index.ts
johnsoncodehk Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions extensions/vscode/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export const { activate, deactivate } = defineExtension(() => {

if (needRestart) {
vscode.window.showInformationMessage(
'Please restart the extension host to activate Vue support in remote environments.',
'Please restart the extension host to activate Vue support.',
'Restart Extension Host',
'Reload Window',
).then(action => {
Expand Down Expand Up @@ -230,12 +230,7 @@ try {
}

if (tsExtension.isActive) {
if (!vscode.env.remoteName) {
vscode.commands.executeCommand('workbench.action.restartExtensionHost');
}
else {
needRestart = true;
}
needRestart = true;
}
}
catch {}
1 change: 0 additions & 1 deletion extensions/vscode/languages/stub.json
View file
Open in desktop

This file was deleted.

9 changes: 1 addition & 8 deletions extensions/vscode/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,7 @@
"vscode": "^1.88.0"
},
"activationEvents": [
"onLanguage:vue",
"onLanguage:markdown",
"onLanguage:html"
"onLanguage"
],
"main": "./dist/extension.js",
"browser": "./web.js",
Expand Down Expand Up @@ -67,11 +65,6 @@
{
"id": "jade",
"configuration": "./languages/sfc-template-language-configuration.json"
},
{
"id": "plaintext",
"configuration": "./languages/stub.json",
"//": "Make sure Vue extension is loaded immediately when VSCode starts."
}
],
"typescriptServerPlugins": [
Expand Down
Loading