Skip to content
This repository was archived by the owner on Jan 18, 2022. It is now read-only.

Support scoped css #87

Merged
merged 10 commits into from
May 3, 2017
Merged

Support scoped css #87

merged 10 commits into from
May 3, 2017

Conversation

ktsn
Copy link
Member

@ktsn ktsn commented May 1, 2017

Changes proposed in this pull request:

  • Support scoped css
    • Inject scope id in component options object in compile time so that all elements in a component has data-v-xxx attribute.
    • Transform css selectors to have scope id. It uses the same logic with vue-loader and vueify.
  • Small refactoring to avoid eslint warning 😛
    • Split processScript function to reduce complexity.

I'm not sure about docs. Should we add 2.4 docs and add about scoped css feature in it?

/ping @znck

@znck
Copy link
Member

znck commented May 2, 2017

I'm not sure about docs. Should we add 2.4 docs and add about scoped css feature in it?

I think updating 2.3 docs with a warning tip would work.

@ktsn
Copy link
Member Author

ktsn commented May 3, 2017

@znck Updated the docs 🙂

Also I just notice the injected code is missing trailing comma. I've fixed it too.

@znck znck merged commit 51cbeae into vuejs:master May 3, 2017
@ktsn ktsn deleted the scoped-css branch May 3, 2017 07:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants