feat(config, theme): add clientOnly marker #4663
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brc-dd Seems like the data loading test on windows-latest could randomly timeout due to fluctuations of GitHub server. There is literally nothing changed in the previous failed test. 
|
|
@zhangyx1998 You need to first resolve some of the conflicts in your code. Just try to cross check. |
|
Thanks for reminding! I'll find time to resolve it asap. |
|
Test/node20 failed because it lacks support for Iterator helpers. The newly introduced package relies on |
|
Could you first create a fork package on npmjs if the pr is not merged for a long time. |
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
clientOnly(object: any)andisClientOnly(object: any): booleanAPIs to mark an object as client-only.ClientOnly.tsto accept an optional propisClientOnly: Booleanso its behavior can be programmatically controlled.Linked Issues
closes #3367
Additional Context
Before (22 occurrences of a sidebar item)
After (4 irrelevant occurrences)
Tip
The author of this PR can publish a preview release by commenting
/publishbelow.