Skip to content

Rewrite FileReader definitions. #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 15, 2019
Merged

Rewrite FileReader definitions. #118

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a1fc3dd
Rewrite FileReader definitions.
mkruisselbrink Mar 8, 2019
4136003
Address comments.
mkruisselbrink Mar 13, 2019
abba774
Address more comments.
mkruisselbrink Mar 14, 2019
2e8b706
Apply suggestions from code review
domenic Mar 14, 2019
613460e
Address even more comments.
mkruisselbrink Mar 14, 2019
c8bb5a2
Use internal slots for FileReader attributes.
mkruisselbrink Mar 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Rewrite FileReader definitions. 
Make algorithms more imperative to make it clearer what is going on.
No intended behavioral changes, but making it clearer that the behavior
from #79 is the expected behavior.
  • Loading branch information
@mkruisselbrink
mkruisselbrink committed Mar 12, 2019
commit a1fc3ddf9c7f075aa466295a9f79662020a79c93
Loading