Use valid UUID in blob: URL example #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The algorithm for creating a blob URL references RFC4122 to generate a UUID. However the example contains an _invalid_ UUID (according to RFC4122): 9115d58c-bcda-ff47-86e5-083e9a215304 This given string is not a valid UUID because it does not contain a meaningful version field (the first character after the second dash).
mkruisselbrink
approved these changes
Apr 6, 2020
|
@marcoscaceres any idea what this "Travis CI - Branch" is this PR seems to be blocked on? I'd expect "Travis CI - Pull Request" to be required, not the branch version, since afaik the branch version doesn't work for pull requests made from forks. Is this some misconfiguration? |
|
Oh, this might be stuck because of the trivisci.com vs travisci.org change... I'll just merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The algorithm for creating a blob URL references RFC4122 to generate a UUID. However the example contains an invalid UUID (according to RFC4122):
9115d58c-bcda-ff47-86e5-083e9a215304This given string is not a valid UUID because it does not contain a meaningful version field (the first character after the second dash).
It could be worthwhile to consider specifying the specific UUID algorithm to be used (Version 4 UUIDs) however that might be an actual change in the spec, not just an editorial change like the one I propose here.
Preview | Diff