Skip to content

[css-values-4][css-images-4] Style resource fetching should probably use credential mode "include" in the default case #12073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
weinig opened this issue Apr 13, 2025 · 1 comment · Fixed by #12074
Closed

[css-values-4][css-images-4] Style resource fetching should probably use credential mode "include" in the default case #12073

weinig opened this issue Apr 13, 2025 · 1 comment · Fixed by #12074

Comments

@weinig
Copy link
Contributor

weinig commented Apr 13, 2025

I was talking with @annevk, and he mentioned that he thought the "fetch a style resource" algorithm in CSS Values 4 should probably follow HTML (and at least what WebKit does) and use credentials mode is "include" rather than "same-origin" as the default value.

This would better match HTML's "create a potential-CORS request" algorithm used for most HTML Subresource fetching.

(@annevk, please correct anything I have wrong here).

cc @tabatkins, @fantasai
@annevk
Copy link
Member

annevk commented Apr 14, 2025

cc @noamr

noamr added a commit to noamr/csswg-drafts that referenced this issue Apr 14, 2025
@noamr
[css-values-4] Use "include" when fetching cross-origin CSS resources
5eea70d 
This matches existing implementation, and was a bug in the
existing spec.

Closes w3c#12073
@noamr noamr mentioned this issue Apr 14, 2025
Merged
tabatkins pushed a commit that referenced this issue Apr 30, 2025
@noamr
[css-values-4] Use "include" when fetching cross-origin CSS resources (…
fc52569 
…#12074)

* [css-values-4] Use "include" when fetching cross-origin CSS resources

This matches existing implementation, and was a bug in the
existing spec.

Closes #12073

* Amend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[css-values-4] Use "include" when fetching cross-origin CSS resources noamr/csswg-drafts
2 participants
@annevk @weinig