-
Notifications
You must be signed in to change notification settings - Fork 711
[css-forms-1] use calc-size() for improved sizing of <button> and <select> #12085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Seems like an improvement over status quo, although I wonder if there's ways we can avoid setting min-block-size / min-inline-size altogether and still meet accessibility requirements (e.g. setting a minimum padding for instance). Min sizes within UA styles always irked me a bit, especially if the developer has a good reason to make something smaller. It often feels like the last thing you would think about overriding, whereas padding is more common to override. |
(Not necessarily suggesting we should use padding, but I'm just saying that default UA min sizes are often overlooked) |
While that might be true I guess if we have a baseline stylesheet people will have, well a baseline to think about. Adjusting minimum sizing will become second nature eventually. |
…id context. This makes the change proposed in w3c/csswg-drafts#12085 whatwg/html#10670 has been updated with this change. Change-Id: I046d73477e15ce6342f2c00193f8131d025c8e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6462875 Reviewed-by: Joey Arhar <[email protected]> Commit-Queue: David Baron <[email protected]> Cr-Commit-Position: refs/heads/main@{#1448995}
…id context. This makes the change proposed in w3c/csswg-drafts#12085 whatwg/html#10670 has been updated with this change. Change-Id: I046d73477e15ce6342f2c00193f8131d025c8e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6462875 Reviewed-by: Joey Arhar <[email protected]> Commit-Queue: David Baron <[email protected]> Cr-Commit-Position: refs/heads/main@{#1448995}
…id context. This makes the change proposed in w3c/csswg-drafts#12085 whatwg/html#10670 has been updated with this change. Change-Id: I046d73477e15ce6342f2c00193f8131d025c8e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6462875 Reviewed-by: Joey Arhar <[email protected]> Commit-Queue: David Baron <[email protected]> Cr-Commit-Position: refs/heads/main@{#1448995}
…select work better in flex/grid context., a=testonly Automatic update from web-platform-tests Make default min sizes for customizable select work better in flex/grid context. This makes the change proposed in w3c/csswg-drafts#12085 whatwg/html#10670 has been updated with this change. Change-Id: I046d73477e15ce6342f2c00193f8131d025c8e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6462875 Reviewed-by: Joey Arhar <[email protected]> Commit-Queue: David Baron <[email protected]> Cr-Commit-Position: refs/heads/main@{#1448995} -- wpt-commits: 0eb7694e58ce18fa3a1b130e4fe3fe65f2b3627c wpt-pr: 52064
…select work better in flex/grid context., a=testonly Automatic update from web-platform-tests Make default min sizes for customizable select work better in flex/grid context. This makes the change proposed in w3c/csswg-drafts#12085 whatwg/html#10670 has been updated with this change. Change-Id: I046d73477e15ce6342f2c00193f8131d025c8e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6462875 Reviewed-by: Joey Arhar <[email protected]> Commit-Queue: David Baron <[email protected]> Cr-Commit-Position: refs/heads/main@{#1448995} -- wpt-commits: 0eb7694e58ce18fa3a1b130e4fe3fe65f2b3627c wpt-pr: 52064
…select work better in flex/grid context., a=testonly Automatic update from web-platform-tests Make default min sizes for customizable select work better in flex/grid context. This makes the change proposed in w3c/csswg-drafts#12085 whatwg/html#10670 has been updated with this change. Change-Id: I046d73477e15ce6342f2c00193f8131d025c8e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6462875 Reviewed-by: Joey Arhar <[email protected]> Commit-Queue: David Baron <[email protected]> Cr-Commit-Position: refs/heads/main@{#1448995} -- wpt-commits: 0eb7694e58ce18fa3a1b130e4fe3fe65f2b3627c wpt-pr: 52064
@lukewarlow This change is ok but we should record a resolution first. |
…select work better in flex/grid context., a=testonly Automatic update from web-platform-tests Make default min sizes for customizable select work better in flex/grid context. This makes the change proposed in w3c/csswg-drafts#12085 whatwg/html#10670 has been updated with this change. Change-Id: I046d73477e15ce6342f2c00193f8131d025c8e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6462875 Reviewed-by: Joey Arhar <jarharchromium.org> Commit-Queue: David Baron <dbaronchromium.org> Cr-Commit-Position: refs/heads/main{#1448995} -- wpt-commits: 0eb7694e58ce18fa3a1b130e4fe3fe65f2b3627c wpt-pr: 52064 UltraBlame original commit: 36be9fc6d979f374344ff81539e36aff23161361
…select work better in flex/grid context., a=testonly Automatic update from web-platform-tests Make default min sizes for customizable select work better in flex/grid context. This makes the change proposed in w3c/csswg-drafts#12085 whatwg/html#10670 has been updated with this change. Change-Id: I046d73477e15ce6342f2c00193f8131d025c8e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6462875 Reviewed-by: Joey Arhar <jarharchromium.org> Commit-Queue: David Baron <dbaronchromium.org> Cr-Commit-Position: refs/heads/main{#1448995} -- wpt-commits: 0eb7694e58ce18fa3a1b130e4fe3fe65f2b3627c wpt-pr: 52064 UltraBlame original commit: 36be9fc6d979f374344ff81539e36aff23161361
…select work better in flex/grid context., a=testonly Automatic update from web-platform-tests Make default min sizes for customizable select work better in flex/grid context. This makes the change proposed in w3c/csswg-drafts#12085 whatwg/html#10670 has been updated with this change. Change-Id: I046d73477e15ce6342f2c00193f8131d025c8e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6462875 Reviewed-by: Joey Arhar <jarharchromium.org> Commit-Queue: David Baron <dbaronchromium.org> Cr-Commit-Position: refs/heads/main{#1448995} -- wpt-commits: 0eb7694e58ce18fa3a1b130e4fe3fe65f2b3627c wpt-pr: 52064 UltraBlame original commit: 36be9fc6d979f374344ff81539e36aff23161361
In #12019 (comment) and in the related presentation I proposed that we change the styles that are currently (for
<button>
and<select>
):into:
This has the advantage that (as described in the examples in the presentation) we no longer override the intrinsic size of the text in the button or select, and thus it defaults to reasonable sizing behavior in flexbox and grid (rather than being willing to shrink down very small).
We didn't resolve on doing that in that issue, and this separate issue is to discuss whether we should in fact make that change. (I think we probably should.)
The text was updated successfully, but these errors were encountered: