Skip to content

[css-text-3] remove unhelpful references to some line breaking classes #3516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
frivoal opened this issue Jan 15, 2019 · 3 comments
Closed
Assignees
Labels
Closed Accepted as Obvious Bugfix Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-text-3 Current Work Testing Unnecessary Memory aid - issue doesn't require tests Tracked in DoC

Comments

@frivoal
Copy link
Collaborator

frivoal commented Jan 15, 2019

Regardless of the white-space value, lines always break at each preserved forced break character: thus for all values, line-breaking behavior defined for the BK, CR, LF, CM, NL, and SG line breaking classes in [UAX14] must be honored.

However:

  • The CR class is just U+0D, which is already handled in Section White Space Processing Details. Doesn’t that make this statement moot for that class?
  • The LF class is just U+0A, which isn’t preserved “regardless of the white-space value”. Also, it is adequately described in the white space section for the cases where it is not discarded.
  • How is CM a forced break?
  • How is SG a forced break? Also, UAX 14 says: The use of this line breaking class is deprecated.

=> Suggestion: remove CR LF CM and SG from this sentence (keep BK and NL).

@frivoal frivoal added the css-text-3 Current Work label Jan 15, 2019
@frivoal frivoal self-assigned this Jan 15, 2019
@fantasai
Copy link
Collaborator

Yes, I think you're right.

@frivoal
Copy link
Collaborator Author

frivoal commented Jan 15, 2019

That looks like no change in behavior, just text clarification. OK to land an edit without a WG resolution?

@fantasai
Copy link
Collaborator

Yes. :)

@frivoal frivoal added the Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. label Jan 15, 2019
@frivoal frivoal added the Testing Unnecessary Memory aid - issue doesn't require tests label Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Accepted as Obvious Bugfix Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-text-3 Current Work Testing Unnecessary Memory aid - issue doesn't require tests Tracked in DoC
Projects
None yet
Development

No branches or pull requests

2 participants