-
Notifications
You must be signed in to change notification settings - Fork 711
[css-view-transitions-1] Spec should not define web exposed keyframes #8887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for bringing this up! Just a heads up, this was last discussed on #7560 and would have relevant context. The main use-case where we've found this useful is additive animations. Authors create effects which need a CSS animation on top of the UA defined one. For example, the UA will add a ::view-transition-group(target) {
animation: -ua-view-transition-group-anim-target 1s, my-animation 1s;
} The keyframe you linked above is static so its easy for authors to just write their own. But some UA keyframes generated for these elements are dynamic (depending on the size/position of the transitioning elements). And for those authors need to be able to refer the keyframe in their CSS for effects like these. @argyleink @bramus FYI. |
@nt1m does the above address the concerns you raised? |
I looked through that other issue and it didn't have context as far as I can could tell:
It's a rather interesting choice to intrude on what was userland space before. |
@annevk the comment thread on the issue itself touches upon some of the complexities associated with hiding this from authors:
Interestingly, at the time we discussed #7560 we were only considering the awkwardness to handle the cases above. We didn't have a use-case where the author needed to refer to these keyframes in their stylesheet. As I mentioned in the comment above, now we've seen developers build transitions which need this to do additive animations. Can you clarify the concerns with this approach? |
I'm closing this issue but please feel free to re-open if there is any more feedback or suggestions. |
https://drafts.csswg.org/css-view-transitions/#ua-styles defines 2 web exposed keyframes, I don't think the spec should do this, regardless of the prefix.
The text was updated successfully, but these errors were encountered: