[css-view-transitions-1] More precisely define snapshot containing block in subframes #9786 #10188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bokand
requested review from
khushalsagar and
noamr
and removed request for
khushalsagar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[css-view-transitions-1] More precisely define snapshot containing block in subframes #9786
The intent of the current definition is that the snapshot containing block in a child frame should be a rect at the origin, the same size as the frame, including any scrollbars.
Initial containing block is misleading in 2 ways - it doesn't include scrollbars in its size and its position changes as the page scrolls so a strict reading would make the snapshot containing block's position dependent on the scroll offset.
I think viewport is the better definition here but I believe that excludes scrollbars as well so we explicitly union it with scrollbar gutters.
Also, refer to child navigable rather than iframes since there's no need to limit this to just iframes (e.g.
<fencedframes>?<frame>?)